SUPPORTENG-984 Correct the 'value' and 'sample' description in the 'FieldChoicesWithLabel' schema #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliangcs
reviewed
Oct 20, 2023
| type: 'string', | ||
| minLength: 1, | ||
| }, | ||
| sample: { | ||
| description: | ||
| "Displayed as light grey text in the editor. It's important that the value match the sample. Otherwise, the actual value won't match what the user picked, which is confusing.", | ||
| "It's important that the value match the sample. Otherwise, the actual value won't match what the user picked, which is confusing.", |
There was a problem hiding this comment.
Suggested change
| "It's important that the value match the sample. Otherwise, the actual value won't match what the user picked, which is confusing.", | |
| "A legacy field that is no longer used by the editor, but it is still required for now and should match the `value`.", |
eliangcs
approved these changes
Oct 20, 2023
Osarhomiyeke
deleted the
SUPPORTENG-984-correct-the-FieldChoiceWithLabelSchema
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.