feat(schema) Add retry and filter to the root-level of throttle config #796
Conversation
| type: 'boolean', | ||
| }, | ||
| filter: { | ||
| description: `EXPERIMENTAL: Account-based attribute to override the throttle by. You can set to one of the following: "free", "trial", "paid". Therefore, the throttle scope would be automatically set to "account" and ONLY the accounts based on the specified filter will have their requests throttled based on the throttle overrides while the rest are throttled based on the original configuration.`, |
There was a problem hiding this comment.
- Can you share why
filteris experimental whileretryis not? - Regarding "the throttle scope would be automatically set to 'account'", what would happen if
scopeis notaccount?
There was a problem hiding this comment.
Regarding "the throttle scope would be automatically set to 'account'", what would happen if scope is not account?
filter is an account-based config setting that uses ONLY account as the scope and disregards any explicit scope set.
Can you share why filter is experimental while retry is not?
I assumed we wanted to open up the retry to the public due to the need it was requested for.
As we're planning on increasing the polling rate for all integrations, we're concerned about one or two apps which might become rate limited and thus, want to throttle them in advance to avoid issues...
Ultimately I think we need to avoid the possibility of stacking up retry attempts faster than they'll actually be processed, causing a pile that only gets bigger with time...
from https://zapier.slack.com/archives/C04P5J5R8E4/p1716513877072559
There was a problem hiding this comment.
@FokkeZB Please, did you intend to make the root-level retry experimental when you suggested it? https://zapier.slack.com/archives/D3YRTGHAM/p1717433047352299
There was a problem hiding this comment.
What's effect of marking it as experimental? Does that imply it's only for internal usage? As the override-level filter property isn't experimental either, I don't see why the root-level one should.
There was a problem hiding this comment.
@FokkeZB Yes, experimental implies internal usage. The override-level filter is experimental indirectly because the override object itself is experimental.
There was a problem hiding this comment.
Ah, ok. I don't have a strong opinion on whether this one should be experimental.
…the throttle config
|
@eliangcs Documented and added a functional constraint test on preventing devs from setting the |
| @@ -83,7 +83,6 @@ BasicHookOperationSchema.properties = { | |||
| inputFields: BasicHookOperationSchema.properties.inputFields, | |||
| outputFields: BasicHookOperationSchema.properties.outputFields, | |||
| sample: BasicHookOperationSchema.properties.sample, | |||
| throttle: BasicHookOperationSchema.properties.throttle, | |||
throttlefor hook trigger.