fix(cli): don't run analytics during tests #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavdid
commented
Oct 17, 2019
| module.exports = { | ||
| ANALYTICS_KEY, | ||
| ANALYTICS_MODES, | ||
| API_PATH, | ||
| AUTH_KEY, | ||
| AUTH_LOCATION, |
There was a problem hiding this comment.
these are just sorting
| // '/Users/david/projects/zapier/platform/node_modules/.bin/mocha', | ||
| // 'src/tests' ] | ||
| const argvStr = process.argv.join(' '); | ||
| const IS_TESTING = |
There was a problem hiding this comment.
we have the same thing in core, helps us to be consistent
| @@ -225,6 +225,14 @@ class ZapierBaseCommand extends Command { | |||
| .join('\n') | |||
| .trim(); | |||
| } | |||
|
|
|||
| _recordAnalytics() { | |||
There was a problem hiding this comment.
this could be overkill, but I did this before finding the bug in analytics.js itself. In any case, it's nice to centralize the behavior.
|
|
||
| describe('testing setup', () => { | ||
| it('should set IS_TESTING to true', () => { | ||
| IS_TESTING.should.be.true(); |
| describe('analytics', () => { | ||
| // causes a lot of noise | ||
| it('should not run analytics when testing', () => { | ||
| shouldSkipAnalytics().should.be.true(); |
There was a problem hiding this comment.
this makes the functionality tough to test. it fixes the problem for now, but we'll probably have to rethink this approach.
| @@ -15,19 +15,22 @@ const setAnalyticsMode = newMode => { | |||
| return writeUserConfig({ [ANALYTICS_KEY]: newMode }); | |||
| }; | |||
|
|
|||
| const shouldSkipAnalytics = mode => | |||
There was a problem hiding this comment.
easier to read this way
| const recordAnalytics = async (command, isValidCommand, args, flags) => { | ||
| const analyticsMode = await currentAnalyticsMode(); | ||
|
|
||
| const shouldRecordAnalytics = | ||
| process.env.DISABLE_ZAPIER_ANALYTICS || | ||
| (process.NODE_ENV !== 'test' && analyticsMode !== ANALYTICS_MODES.disabled); |
There was a problem hiding this comment.
❗️ the actual bug was having process.NODE_ENV instead of process.env.NODE_ENV
eliangcs
approved these changes
Oct 17, 2019
This was referenced Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a big surge of analytics on
linuxwith odd behavior, such as no command (which should never be possible). Turns out the culprit was traivs. Fixed some minor bugs while I was in there.