Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue while trying to install or download zappa without binary file #1199

Closed
sridhar562345 opened this issue Nov 29, 2022 · 2 comments
Closed

Comments

@sridhar562345
Copy link
Contributor

sridhar562345 commented Nov 29, 2022

Context

When trying to install zappa without binary file facing the following issue, tested the same in python3.7, python3.8 and python3.9

Expected Behavior

Should be able to download

Actual Behavior

pip3.9 download --no-binary :all: zappa --no-deps
Looking in indexes: https://pypi.python.org/simple
Collecting zappa
  Downloading zappa-0.55.0.tar.gz (166 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 166.5/166.5 kB 893.5 kB/s eta 0:00:00
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error
  
  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [8 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/tmp/pip-download-2qug6bqt/zappa_d50c219a10d445f6916cf40967821092/setup.py", line 15, in <module>
          "{}{}".format(name, version.strip('"')) if version != '"*"' else name for name, version in pipfile["packages"].items()
        File "/usr/lib/python3.9/configparser.py", line 963, in __getitem__
          raise KeyError(key)
      KeyError: 'packages'
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

Possible Fix

The reason might be due to the incorrect parsing of Pipfile in setup.py

Steps to Reproduce

pip3.9 download --no-binary :all: zappa --no-deps

Your Environment

  • Zappa version used: 0.55.0
  • Operating System and Python version: Ubuntu 20.04, python3.7, python3.8 and python3.9
  • The output of pip freeze:
  • Link to your project (optional):
  • Your zappa_settings.json:
@monkut
Copy link
Collaborator

monkut commented Nov 29, 2022

Seems that the Pipfile is not included in the built tar.

image

monkut added a commit that referenced this issue Nov 29, 2022
…irements.txt, requirements.in test_requirements.in. Replacing in MANIFEST.in.

Related Issue:
#1199
monkut added a commit that referenced this issue Nov 29, 2022
monkut added a commit that referenced this issue Dec 1, 2022
* 📝 CHANGELOG.md update for 0.55.1 release

* 📝 add merged PR (#1177) related issues to CHANGELOG.

* 📝 add #1117 to list after merge.

* 📝 adding resolved issue to CHANGELOG

* 🔧 0.55.1 -> 0.56.0
📝 add merged issue to changelog.

* 📝 add #1190

* 🔧 `Pipfile` (pipenv) now used in place of requirements.txt, test_requirements.txt, requirements.in test_requirements.in. Replacing in MANIFEST.in.

Related Issue:
#1199

* 🔧 Add resolved issue #1199
@monkut
Copy link
Collaborator

monkut commented Dec 1, 2022

Confirmed Pipfile is now included in the resulting pypi package.

image

released in 0.56.0, closing.

@monkut monkut closed this as completed Dec 1, 2022
Ian288 pushed a commit to tackle-io/Zappa that referenced this issue Jul 11, 2023
* 📝 CHANGELOG.md update for 0.55.1 release

* 📝 add merged PR (zappa#1177) related issues to CHANGELOG.

* 📝 add zappa#1117 to list after merge.

* 📝 adding resolved issue to CHANGELOG

* 🔧 0.55.1 -> 0.56.0
📝 add merged issue to changelog.

* 📝 add zappa#1190

* 🔧 `Pipfile` (pipenv) now used in place of requirements.txt, test_requirements.txt, requirements.in test_requirements.in. Replacing in MANIFEST.in.

Related Issue:
zappa#1199

* 🔧 Add resolved issue zappa#1199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants