Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Migrated] #2077 Fix url decoding for query string #879

Closed
jneves opened this issue Feb 20, 2021 · 2 comments
Closed

[Migrated] #2077 Fix url decoding for query string #879

jneves opened this issue Feb 20, 2021 · 2 comments

Comments

@jneves
Copy link
Contributor

jneves commented Feb 20, 2021

Originally from: Miserlou/Zappa#2134 by choich

Description

Add unquote for query string

GitHub Issues

#2077

@monkut
Copy link
Collaborator

monkut commented Jul 16, 2022

need to review and understand if this is an issue.

@monkut monkut added the has-pr label Jul 16, 2022
monkut added a commit to choich/Zappa-1 that referenced this issue Aug 12, 2022
@monkut monkut self-assigned this Aug 16, 2022
monkut added a commit that referenced this issue Oct 6, 2022
* ✨ Handle spaces in x-forwared-for (#1127)

* 🔥 remove `six` (no longer needed as 2.x is no longer supported)

* ✅ add testcase for SUPPORTED_VERSION check to increase code coverage.

* 🎨 run black/isort

* 🔧 rename function for clarity

* 🔥 remove unnecessary import

* 🔧 change name of unused mock instance

* ✨ (#879) Fix url decoding for query string

* 🔧 change docstring type multi-line comment to standard multiline comment
✨ handle case where "requestContext" is not provided by the event.

> Systems calling the Lambda (other than API Gateway) may not provide the field requestContext in the event.

✅ add testcases

* 🔥 remove duplicate comment

* 📝 add docstring to util function, `get_unsupported_sys_versioninfo()`

* 🔥 remove double-underscore
monkut added a commit that referenced this issue Nov 24, 2022
* ✨ Handle spaces in x-forwared-for (#1127)

* 🔥 remove `six` (no longer needed as 2.x is no longer supported)

* ✅ add testcase for SUPPORTED_VERSION check to increase code coverage.

* 🎨 run black/isort

* 🔧 rename function for clarity

* 🔥 remove unnecessary import

* 🔧 change name of unused mock instance

* ✨ (#879) Fix url decoding for query string

* 🔧 change docstring type multi-line comment to standard multiline comment
✨ handle case where "requestContext" is not provided by the event.

> Systems calling the Lambda (other than API Gateway) may not provide the field requestContext in the event.

✅ add testcases

* 🔥 remove duplicate comment

* 📝 add docstring to util function, `get_unsupported_sys_versioninfo()`

* ✨ Add any python version support in the case where code is run in docker

* 🎨 run black/isort

* ✅ fix testcase
✅ update testcase to output the full filepath of file you are expected to compare the README.md to.

* 🔧 Add python minor version check when using docker.

* 🎨 fix flake8

* 🔧 don't limit the upper version of zappa on setup.  Internal checks will perform version check, but docker based installs shouldn't be capped.
@monkut
Copy link
Collaborator

monkut commented Dec 1, 2022

released in 0.56.0, closing.

@monkut monkut closed this as completed Dec 1, 2022
Ian288 pushed a commit to tackle-io/Zappa that referenced this issue Jul 11, 2023
* ✨ Handle spaces in x-forwared-for (zappa#1127)

* 🔥 remove `six` (no longer needed as 2.x is no longer supported)

* ✅ add testcase for SUPPORTED_VERSION check to increase code coverage.

* 🎨 run black/isort

* 🔧 rename function for clarity

* 🔥 remove unnecessary import

* 🔧 change name of unused mock instance

* ✨ (zappa#879) Fix url decoding for query string

* 🔧 change docstring type multi-line comment to standard multiline comment
✨ handle case where "requestContext" is not provided by the event.

> Systems calling the Lambda (other than API Gateway) may not provide the field requestContext in the event.

✅ add testcases

* 🔥 remove duplicate comment

* 📝 add docstring to util function, `get_unsupported_sys_versioninfo()`

* 🔥 remove double-underscore
Ian288 pushed a commit to tackle-io/Zappa that referenced this issue Jul 11, 2023
* ✨ Handle spaces in x-forwared-for (zappa#1127)

* 🔥 remove `six` (no longer needed as 2.x is no longer supported)

* ✅ add testcase for SUPPORTED_VERSION check to increase code coverage.

* 🎨 run black/isort

* 🔧 rename function for clarity

* 🔥 remove unnecessary import

* 🔧 change name of unused mock instance

* ✨ (zappa#879) Fix url decoding for query string

* 🔧 change docstring type multi-line comment to standard multiline comment
✨ handle case where "requestContext" is not provided by the event.

> Systems calling the Lambda (other than API Gateway) may not provide the field requestContext in the event.

✅ add testcases

* 🔥 remove duplicate comment

* 📝 add docstring to util function, `get_unsupported_sys_versioninfo()`

* ✨ Add any python version support in the case where code is run in docker

* 🎨 run black/isort

* ✅ fix testcase
✅ update testcase to output the full filepath of file you are expected to compare the README.md to.

* 🔧 Add python minor version check when using docker.

* 🎨 fix flake8

* 🔧 don't limit the upper version of zappa on setup.  Internal checks will perform version check, but docker based installs shouldn't be capped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants