Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow specifying artifact name #45

Closed
iamjoeker opened this issue Dec 14, 2020 · 6 comments · Fixed by #64
Closed

Feature Request: Allow specifying artifact name #45

iamjoeker opened this issue Dec 14, 2020 · 6 comments · Fixed by #64

Comments

@iamjoeker
Copy link

I use a single workflow file to run zap scans on multiple sites. Each site is its own job so they can fail or succeed independently. However, since the artifact name is hard-coded, only the report of the last job to complete is saved.

Would the project be open to a adding support for specifying the artifact name as an option? I'd be glad to submit PRs both here and in actions-common to add this.

@psiinon
Copy link
Member

psiinon commented Dec 21, 2020

Sounds good to me! PR much appreciated :)

@AlexDCraig
Copy link
Contributor

I would also like this. Maybe I will work on this sometime.

@AlexDCraig
Copy link
Contributor

@psiinon this issue is resolved with the merging in of this patch to the upstream common library (zaproxy/actions-common#15) and this patch to this repo (#64)

@Israphel
Copy link

is this feature available to be used yet?

@psiinon
Copy link
Member

psiinon commented Apr 22, 2022

Sorry no, #64 hasnt been merged yet - its still WIP, I'll see whats blocking it...

@Israphel
Copy link

I'm using a workaround for the moment, if anybody is interested:

  job-one:
    name: Dast report for site one
    runs-on: ubuntu-latest
    steps:
      - name: ZAP Scan
        uses: zaproxy/action-api-scan@v0.1.0
        with:
          issue_title: site-one
          token: ${{ secrets.GITHUB_TOKEN }}
          fail_action: false
          target: 'https://siteone.com'
          format: openapi

      - name: Upload report
        uses: actions/upload-artifact@v3
        with:
          name: custom_name.zip
          path: zap_scan.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants