Update Gradle to 8.5, use Java 21 in CI #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Gradle Wrapper to 8.5 and ZAP API client to latest version. Apply the common plugins and remove now redundant configurations. Address deprecation warning when using `project.buildDir`. Update GitHub Actions in workflows and add Java 21 to CI. Signed-off-by: thc202 <thc202@gmail.com>
kingthorin
reviewed
Nov 30, 2023
Comment on lines
-26
to
-36
| tasks.withType<JavaCompile>().configureEach { | ||
| options.encoding = "UTF-8" | ||
| options.compilerArgs = listOf("-Xlint:all", "-Xlint:-path", "-Xlint:-options", "-Werror") | ||
| } | ||
|
|
||
| spotless { | ||
| java { | ||
| licenseHeaderFile("$rootDir/gradle/spotless/license.java") | ||
| googleJavaFormat().aosp() | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't think this is wrong but how do these bits happen now?
There was a problem hiding this comment.
The common plugin does that.
kingthorin
approved these changes
Nov 30, 2023
psiinon
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Gradle Wrapper to 8.5 and ZAP API client to latest version.
Apply the common plugins and remove now redundant configurations.
Address deprecation warning when using
project.buildDir.Update GitHub Actions in workflows and add Java 21 to CI.