Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert i18n bug #235

Closed
psiinon opened this issue Nov 8, 2018 · 0 comments · Fixed by #641
Closed

Alert i18n bug #235

psiinon opened this issue Nov 8, 2018 · 0 comments · Fixed by #641
Labels
bug Good First Issue This is a great issue for a first time contributor to start with.
Milestone
0.9.0

Comments

@psiinon
Copy link
Member

psiinon commented Nov 8, 2018

The alert internationalisation isnt quite right.
In UIMessages.properties set:
alerts_risk_info = Info
(if its not already).
Run the HUD and click on the Info alerts tool - the alerts dialog will be shown but the Info panel will not be selected. Thats because the code is using the string Informational, probably from here:

It should be using the i18n'd messages instead.
It might not be a trivial fix, the hardcoded string is probably used to access the alerts from the ZAP API, so we'll need to make sure the right string is used at the right time.
My guess is that the alert selection will fail for other languages, eg French.
@psiinon psiinon added bug Good First Issue This is a great issue for a first time contributor to start with. labels Nov 8, 2018
Rshahatit pushed a commit to Rshahatit/zap-hud that referenced this issue Nov 26, 2019
Alert i18n bug zaproxy#235 FIXED
931d82d
@Rshahatit Rshahatit mentioned this issue Nov 26, 2019
Merged
@thc202 thc202 added this to the 0.9.0 milestone Nov 26, 2019
Rshahatit added a commit to Rshahatit/zap-hud that referenced this issue Nov 28, 2019
@Rshahatit
Alert i18n bug zaproxy#235 FIXED
3305f35
Rshahatit added a commit to Rshahatit/zap-hud that referenced this issue Nov 30, 2019
@Rshahatit
Alert i18n bug zaproxy#235 FIXED
bcb7d8e 
changed from TEXT to LABEL and added fix to changelog

changed HUDAPI quotes and service worker syntax back

updated changelog with issue link
thc202 added a commit that referenced this issue Dec 2, 2019
@thc202
Merge pull request #641 from Rshahatit/develop
1cd16e7 
Bugfix/Alert i18n bug #235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Good First Issue This is a great issue for a first time contributor to start with.
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

Bugfix/Alert i18n bug #235 Rshahatit/zap-hud
2 participants
@psiinon @thc202