Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not found response tab on options (keyboard shortcut setting) #5165

Closed
hahwul opened this issue Dec 28, 2018 · 7 comments · Fixed by #6497
Closed

Not found response tab on options (keyboard shortcut setting) #5165

hahwul opened this issue Dec 28, 2018 · 7 comments · Fixed by #6497
Assignees
@thc202
Labels
bug Component-UI Usability
Milestone
2.11.0

Comments

@hahwul
Copy link

hahwul commented Dec 28, 2018

Describe the bug
Not found response tab on options(keyboard shortcut setting)
tweet link: https://twitter.com/hahwul/status/1078150715359424513

To Reproduce
Steps to reproduce the behavior:

  1. Launch ZAP Weekly(D-2018-12-17)
  2. Open ZAP Preferences(options)
  3. Click Keyboard menu
  4. Not found response ..

Expected behavior
Can not set a keyboard shortcut for the response tab.

Screenshots
1414
1415

Software versions

  • ZAP: D-2018-12-17(Weekly download)
  • Add-on: No add-on issue.
  • OS: macOS Mojave(10.14.2)
  • Java: 1.8.0_152
  • Browser: No browser issue. ( I use firefox )

Errors from the zap.log file
um.. is this? There is no error when executed from the command line.

9466 [ZAP-BootstrapGUI] INFO org.zaproxy.zap.extension.callback.ExtensionCallback  - Started callback server on 0.0.0.0:57929
9466 [ZAP-BootstrapGUI] INFO org.zaproxy.zap.extension.keyboard.ExtensionKeyboard  - Initializing keyboard shortcuts
9767 [AWT-EventQueue-0] INFO org.parosproxy.paros.control.Control  - New Session
9882 [AWT-EventQueue-0] INFO org.parosproxy.paros.control.Control  - Create and Open Untitled Db

Additional context
@hahwul hahwul added the bug label Dec 28, 2018
@kingthorin
Copy link
Member

kingthorin commented Dec 28, 2018 •
edited

Confirmed, I switched to the 2.6.0 tag in the repo and when I run it I do see a Response Tab options:
image

@kingthorin
Copy link
Member

kingthorin commented Dec 28, 2018 •
edited

Seems to have gone missing between w2018-03-12 and w2018-03-19.

In fact it seems all the hotkeys with 3 modifiers (ctrl+alt+shift) disappeared at that point, perhaps due to the look and feel changes?
Comparison: w2018-03-12...zaproxy:w2018-03-19

@hahwul
Copy link
Author

hahwul commented Dec 30, 2018

@kingthorin
If so.. it's not just the issue of the only weekly (2018-12-17) version. I saw compare commit&code of look and feel but, I not found issue point (I don't know the ZAP Core code yet)

Please tell me if you need help :)

@thc202 thc202 added the weekly label Jan 7, 2019
@thc202
Copy link
Member

thc202 commented Jan 7, 2019

This affects only weekly releases (broken by #4511).

@thc202 thc202 self-assigned this Jan 7, 2019
@thc202
Copy link
Member

thc202 commented Jan 7, 2019

@kingthorin that was already fixed (not related to the number of modifiers though, it was the visible state of the tabs).

@kingthorin
Copy link
Member

kingthorin commented Jan 7, 2019 •
edited

Great.

@thc202 thc202 removed the weekly label Mar 29, 2021
@thc202 thc202 changed the title Not found response tab on options(keyboard shortcut setting) Not found response tab on options (keyboard shortcut setting) Mar 29, 2021
thc202 added a commit to thc202/zaproxy that referenced this issue Mar 29, 2021
@thc202
Keep track of inserted tabs
badba96 
Change `TabbedPanel2` to track also tabs inserted, not all of them are
added (e.g. Response tab might be inserted when changing the layout of
the Request/Response panels).

Fix zaproxy#5165.

Signed-off-by: thc202 <thc202@gmail.com>
@thc202 thc202 mentioned this issue Mar 29, 2021
Merged
@thc202 thc202 added this to the 2.11.0 milestone Mar 29, 2021
kosap pushed a commit to kosap/zaproxy that referenced this issue Jun 3, 2021
@thc202 @kosap
Keep track of inserted tabs
d14441c 
Change `TabbedPanel2` to track also tabs inserted, not all of them are
added (e.g. Response tab might be inserted when changing the layout of
the Request/Response panels).

Fix zaproxy#5165.

Signed-off-by: thc202 <thc202@gmail.com>
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@thc202 thc202

Labels
bug Component-UI Usability
Milestone
2.11.0
Development

Successfully merging a pull request may close this issue.

Keep track of inserted tabs thc202/zaproxy
3 participants
@thc202 @kingthorin @hahwul