Allow arbitrary HTTP versions #7456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the validation of the HTTP version in request/response headers. Tweak the HTTP version regular expression to allow only major version. Does not add support for newer HTTP versions (though the messages can still be sent) but allows to represent newer versions in plain text. Signed-off-by: thc202 <thc202@gmail.com>
thc202
added a commit
to thc202/zap-extensions
that referenced
this pull request
Sep 12, 2022
Check that the minor HTTP version is present when converting it, in case the message is being sent with just the major version. Related to zaproxy/zaproxy#7456. Signed-off-by: thc202 <thc202@gmail.com>
kingthorin
approved these changes
Sep 12, 2022
psiinon
approved these changes
Sep 13, 2022
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the validation of the HTTP version in request/response headers.
Tweak the HTTP version regular expression to allow only major version.
Does not add support for newer HTTP versions (though the messages can
still be sent) but allows to represent newer versions in plain text.