Allow to set a certificates service #6946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `SSLConnector` to allow to set the certificates service, for the network add-on to set a custom one (legacy support). Change `ExtensionDynSSL` to set the default. Signed-off-by: thc202 <thc202@gmail.com>
thc202
force-pushed
the
sslconnector/set-service
branch
from
7022ddf
to
b000c23
Compare
kingthorin
approved these changes
Nov 23, 2021
psiinon
approved these changes
Nov 23, 2021
thc202
added a commit
to thc202/zaproxy
that referenced
this pull request
Nov 28, 2021
Change to set the certificates service in a finally block to ensure it's set always, when starting with clean home it would not be set. Issue introduced in zaproxy#6946. Signed-off-by: thc202 <thc202@gmail.com>
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
SSLConnectorto allow to set the certificates service, for thenetwork add-on to set a custom one (legacy support).
Change
ExtensionDynSSLto set the default.