feat: improves PHP generation. #7513
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcchavezs
commented
Oct 8, 2022
zap/src/main/java/org/zaproxy/zap/extension/api/PhpAPIGenerator.java
Outdated
Show resolved
Hide resolved
jcchavezs
commented
Oct 8, 2022
|
|
||
| if (hasParams) { | ||
| out.write(", "); | ||
| } | ||
| // Always add the API key - we've no way of knowing if it will be required or not | ||
| out.write("$" + API.API_KEY_PARAM + "='') {\n"); | ||
| out.write("string $" + API.API_KEY_PARAM + " = '') {\n"); |
jcchavezs
commented
Oct 8, 2022
zap/src/main/java/org/zaproxy/zap/extension/api/PhpAPIGenerator.java
Outdated
Show resolved
Hide resolved
While we can't improve arguments because lack of typing, this is a best effort to improve the code. Signed-off-by: José Carlos Chávez <jcchavezs@gmail.com>
jcchavezs
force-pushed
the
improves_php_generator
branch
from
e2bbe59
to
9a3a395
Compare
|
The build failed: |
Signed-off-by: José Carlos Chávez <jcchavezs@gmail.com>
jcchavezs
force-pushed
the
improves_php_generator
branch
from
afcf10b
to
d856850
Compare
Signed-off-by: José Carlos Chávez <jcchavezs@gmail.com>
psiinon
approved these changes
Oct 11, 2022
Signed-off-by: José Carlos Chávez <jcchavezs@gmail.com>
|
|
Signed-off-by: José Carlos Chávez <jcchavezs@gmail.com>
|
Fixed @psiinon |
|
Ping @thc202 |
jcchavezs
commented
Oct 21, 2022
| out.write(reqParams.toString()); | ||
| out.write(";\n"); | ||
| reqParams.replace(0, reqParams.length(), "$params"); | ||
|
|
||
| for (ApiParameter parameter : optionalParameters) { | ||
| String name = parameter.getName(); | ||
| String varName = name.toLowerCase(Locale.ROOT); | ||
| out.write("\t\tif ($" + varName + " !== NULL) {\n"); |
There was a problem hiding this comment.
Switched tabs into spaces as that is what is being used by standards. In any case, all the code is reformatted by proper PHP linters in the PHP API client.
thc202
reviewed
Oct 21, 2022
| @@ -34,6 +34,9 @@ | |||
| import java.util.ResourceBundle; | |||
| import java.util.stream.Collectors; | |||
|
|
|||
| /* | |||
Comment on lines
+92
to
+103
| /** | ||
| * Generates the API client files of the given API implementors. | ||
| * | ||
| * @param implementors the implementors | ||
| * @throws IOException if an error occurred while generating the APIs. | ||
| * @deprecated (2.6.0) Use {@link #generateAPIFiles(List)} instead. | ||
| */ | ||
| @Deprecated | ||
| public void generatePhpFiles(List<ApiImplementor> implementors) throws IOException { | ||
| this.generateAPIFiles(implementors); | ||
| } | ||
|
|
|
Commits should be squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we can't improve arguments because lack of typing, this is a best effort to improve the code.
Ping @psiinon