Do not use null domain in auth credentials #8498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use an empty string for the domain when creating the auth credentials as null is not allowed. Signed-off-by: thc202 <thc202@gmail.com>
psiinon
approved these changes
May 28, 2024
thc202
added a commit
to thc202/zap-extensions
that referenced
this pull request
May 28, 2024
Set an empty realm instead, as null is not allowed and would break the authentication. Related to zaproxy/zaproxy#8498. Signed-off-by: thc202 <thc202@gmail.com>
thc202
added a commit
to thc202/zap-extensions
that referenced
this pull request
May 28, 2024
Check that the user actually has an auth state before trying to use it, which could happen if the auth attempt lead to an error. Related to zaproxy/zaproxy#8498. Signed-off-by: thc202 <thc202@gmail.com>
kingthorin
approved these changes
May 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an empty string for the domain when creating the auth credentials as null is not allowed.