Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored ZestBasicRunner not to depend on HttpClient. #118

Merged
merged 2 commits into from
Sep 18, 2017
Merged

Refactored ZestBasicRunner not to depend on HttpClient. #118

merged 2 commits into from
Sep 18, 2017

Conversation

denniskniep
Copy link
Member

Instead use an interface.

thc202
thc202 reviewed Sep 13, 2017
View reviewed changes
Copy link
Member

@thc202 thc202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ZestBasicRunner has a lot of unused imports that should be removed.

src/main/java/org/mozilla/zest/core/v1/ZestCookie.java Outdated Show resolved Hide resolved
src/main/java/org/mozilla/zest/core/v1/ZestCookie.java Outdated Show resolved Hide resolved
src/main/java/org/mozilla/zest/core/v1/ZestRequest.java Outdated Show resolved Hide resolved
src/main/java/org/mozilla/zest/core/v1/ZestRequest.java Outdated Show resolved Hide resolved
src/main/java/org/mozilla/zest/core/v1/ZestRequest.java Outdated Show resolved Hide resolved
src/main/java/org/mozilla/zest/impl/HttpClientWrapper.java Outdated Show resolved Hide resolved
src/main/java/org/mozilla/zest/impl/ZestBasicRunner.java Outdated Show resolved Hide resolved
src/main/java/org/mozilla/zest/impl/ZestBasicRunner.java Show resolved Hide resolved
src/main/java/org/mozilla/zest/impl/ZestHttpClient.java Outdated Show resolved Hide resolved
src/test/java/org/mozilla/zest/test/v1/ZestRequestUnitTest.java Outdated Show resolved Hide resolved
@denniskniep
Copy link
Member Author

@thc202 I squashed the commits into one refactoring commit and one bugfix commit.

@thc202
Copy link
Member

thc202 commented Sep 15, 2017

Thank you!

@psiinon psiinon merged commit 4eae5bc into zaproxy:develop Sep 18, 2017
@thc202 thc202 mentioned this pull request Jun 20, 2018
Closed
@thc202 thc202 added this to the 0.14.0 milestone Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psiinon psiinon psiinon approved these changes

@thc202 thc202 thc202 approved these changes

Assignees
No one assigned
Labels
enhancement
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@denniskniep @thc202 @psiinon