Update Selenium and PhantomJS driver #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Selenium to 3.5.3 and PhantomJS driver to 1.4.3 (which uses a newer version of Selenium). Update test to match the new behaviour (select's type is now returned), test passes with Chrome (59), Firefox (55), PhantomJS (2.1.1), and Htmlunit (2.27, version bundled in Selenium). Related to zaproxy/zaproxy#3830 - Update to Selenium 3.5
psiinon
approved these changes
Sep 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Selenium to 3.5.3 and PhantomJS driver to 1.4.3 (which uses a
newer version of Selenium).
Update test to match the new behaviour (select's type is now returned),
test passes with Chrome (59), Firefox (55), PhantomJS (2.1.1), and
Htmlunit (2.27, version bundled in Selenium).
Related to zaproxy/zaproxy#3830 - Update to Selenium 3.5