Change action invoke to allow to set the charset #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change ZestActionInvoke to allow to set the charset used in read operations, to ensure the script is loaded or the output of the program read, always with expected charset (if not it would rely on the JVM default charset, which is not always the same). Update tests to check that the charset is de/serialised. Related to zaproxy/zaproxy#3377 - ZAP can no longer load non UTF8 scripts
psiinon
approved these changes
Sep 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change ZestActionInvoke to allow to set the charset used in read
operations, to ensure the script is loaded or the output of the program
read, always with expected charset (if not it would rely on the JVM
default charset, which is not always the same).
Update tests to check that the charset is de/serialised.
Related to zaproxy/zaproxy#3377 - ZAP can no longer load non UTF8
scripts