Accept insecure certs when launching browsers #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change ZestClientLaunch to accept "insecure" certificates when launching the browsers, to improve the interoperability with sites and other tools (for example, ZAP which uses a custom Root CA certificate). The following browsers are accepting the "insecure" certificates: Chrome, Firefox, HtmlUnit, JBD, and PhantomJS. Chrome and HtmlUnit were already accepting the insecure certs. For Chrome it was disabled the headless mode because of an issue that prevents the certs from being accepted when in headless mode.
psiinon
approved these changes
Sep 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change ZestClientLaunch to accept "insecure" certificates when launching
the browsers, to improve the interoperability with sites and other tools
(for example, ZAP which uses a custom Root CA certificate).
The following browsers are accepting the "insecure" certificates:
Chrome, Firefox, HtmlUnit, JBD, and PhantomJS.
Chrome and HtmlUnit were already accepting the insecure certs. For
Chrome it was disabled the headless mode because of an issue that
prevents the certs from being accepted when in headless mode.