Skip to content

Commit

Permalink
Merge pull request adafruit#1721 from tannewt/fix_hid_report_lookup
Browse files Browse the repository at this point in the history
Fix HID buffer lookup
  • Loading branch information
dhalbert committed Mar 28, 2019
2 parents fd134df + 9232ec5 commit c6e3b17
Showing 1 changed file with 13 additions and 7 deletions.
20 changes: 13 additions & 7 deletions shared-module/usb_hid/Device.c
Expand Up @@ -60,27 +60,33 @@ void common_hal_usb_hid_device_send_report(usb_hid_device_obj_t *self, uint8_t*
}
}

static usb_hid_device_obj_t* get_hid_device(uint8_t report_id) {
for (uint8_t i = 0; i < USB_HID_NUM_DEVICES; i++) {
if (usb_hid_devices[i].report_id == report_id) {
return &usb_hid_devices[i];
}
}
return NULL;
}

// Callbacks invoked when receive Get_Report request through control endpoint
uint16_t tud_hid_generic_get_report_cb(uint8_t report_id, hid_report_type_t report_type, uint8_t* buffer, uint16_t reqlen) {
// only support Input Report
if ( report_type != HID_REPORT_TYPE_INPUT ) return 0;

// index is ID-1
uint8_t idx = ( report_id ? (report_id-1) : 0 );

// fill buffer with current report
memcpy(buffer, usb_hid_devices[idx].report_buffer, reqlen);
memcpy(buffer, get_hid_device(report_id)->report_buffer, reqlen);
return reqlen;
}

// Callbacks invoked when receive Set_Report request through control endpoint
void tud_hid_generic_set_report_cb(uint8_t report_id, hid_report_type_t report_type, uint8_t const* buffer, uint16_t bufsize) {
// index is ID-1
uint8_t idx = ( report_id ? (report_id-1) : 0 );
usb_hid_device_obj_t* hid_device = get_hid_device(report_id);

if ( report_type == HID_REPORT_TYPE_OUTPUT ) {
// Check if it is Keyboard device
if ( (usb_hid_devices[idx].usage_page == HID_USAGE_PAGE_DESKTOP) && (usb_hid_devices[idx].usage == HID_USAGE_DESKTOP_KEYBOARD) ) {
if (hid_device->usage_page == HID_USAGE_PAGE_DESKTOP &&
hid_device->usage == HID_USAGE_DESKTOP_KEYBOARD) {
// This is LED indicator (CapsLock, NumLock)
// TODO Light up some LED here
}
Expand Down

0 comments on commit c6e3b17

Please sign in to comment.