Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support external registry on zarf init #560

Closed
4 tasks
jeff-mccoy opened this issue Jun 24, 2022 · 0 comments · Fixed by #754
Closed
4 tasks

Support external registry on zarf init #560

jeff-mccoy opened this issue Jun 24, 2022 · 0 comments · Fixed by #754
Assignees

Comments

@jeff-mccoy
Copy link
Contributor

jeff-mccoy commented Jun 24, 2022

In support of #376, Zarf should be able to use an external registry as an alternative to the injector, seed registry and registry components in the init package currently. When an external registry is available, the connection info should be placed in the zarf-state secret and used everywhere appropriately.

  • Zarf init accepts a host, user, password flags
  • Update ZarfState to accept an override for the password in lieu of the calculated password
  • All calls, including the Zarf Agent, should use these variables vs hardcoding 127.0.0.1:31999
  • Docs should be updated to explain when this is useful such as when used with another Zarf Cluster acting as a Utility Cluster #186 or in egress-restricted cloud environments
@mike-winberry mike-winberry self-assigned this Jul 7, 2022
@YrrepNoj YrrepNoj assigned YrrepNoj and unassigned mike-winberry Sep 26, 2022
jeff-mccoy added a commit that referenced this issue Sep 29, 2022
…754)

## Description
This PR introduces the ability to connect to an already existing (and
reachable) Container Registry and/or Git Repository during the `zarf
init` command.

Closes #570 (Support using an external git server)
Closes #560 (Support using an external registry)
This implementation will serve as a good midway point on having a fully
HA in-cluster registry #375.



## PR Feature List
- Added several flags to the `init` command to support using an external
git repository
- Added several flags to the `init` command to support using an external
container registry
- Update `zarf connect registry` to direct to `{HOST}/v2/_catalog` (this
was confusing some other people since it would originally seem like the
registry was returning an empty page)
- Add utility function to create a tunnel to a service URL
- Created slightly better regexp for replacing the host from a
`containerImage` url
- semi-refactored the `zarf package deploy` logic


## Breaking Changes List
- We are changing the structure of the names of repos & containers we
are pushing (we are simplifying the name and adding a sha1 hash of the
original name to the end of the name)

Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Co-authored-by: Megamind <882485+jeff-mccoy@users.noreply.github.com>
Noxsios pushed a commit that referenced this issue Mar 8, 2023
…754)

## Description
This PR introduces the ability to connect to an already existing (and
reachable) Container Registry and/or Git Repository during the `zarf
init` command.

Closes #570 (Support using an external git server)
Closes #560 (Support using an external registry)
This implementation will serve as a good midway point on having a fully
HA in-cluster registry #375.



## PR Feature List
- Added several flags to the `init` command to support using an external
git repository
- Added several flags to the `init` command to support using an external
container registry
- Update `zarf connect registry` to direct to `{HOST}/v2/_catalog` (this
was confusing some other people since it would originally seem like the
registry was returning an empty page)
- Add utility function to create a tunnel to a service URL
- Created slightly better regexp for replacing the host from a
`containerImage` url
- semi-refactored the `zarf package deploy` logic


## Breaking Changes List
- We are changing the structure of the names of repos & containers we
are pushing (we are simplifying the name and adding a sha1 hash of the
original name to the end of the name)

Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Co-authored-by: Megamind <882485+jeff-mccoy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants