Update post-renderer to verify secret data for existing secrets #331
Conversation
| @@ -40,6 +40,10 @@ var destroyCmd = &cobra.Command{ | |||
|
|
|||
| // If Zarf didn't deploy the cluster, only delete the ZarfNamespace | |||
| k8s.DeleteZarfNamespace() | |||
|
|
|||
| // Delete the zarf-registry secret in the default namespace | |||
| defaultSecret, _ := k8s.GetSecret("default", "zarf-registry") | |||
There was a problem hiding this comment.
@jeff-mccoy Should we just delete all the zarf-registry secrets across all the namespaces? I can't think of a good reason to keep the secrets if we're doing a destroy since the registry the creds are for won't exist anymore.
There was a problem hiding this comment.
sorry I must have skipped it since it was out of date and didnt have latest commit tested
There was a problem hiding this comment.
this is fine for now, we need to discuss this vs the "created-by" label tracking for deletion of resources at some point.
|
/test all |
|
@jeff-mccoy Friendly ping to ask you to give this a review when you have some time :) |
| @@ -40,6 +40,10 @@ var destroyCmd = &cobra.Command{ | |||
|
|
|||
| // If Zarf didn't deploy the cluster, only delete the ZarfNamespace | |||
| k8s.DeleteZarfNamespace() | |||
|
|
|||
| // Delete the zarf-registry secret in the default namespace | |||
| defaultSecret, _ := k8s.GetSecret("default", "zarf-registry") | |||
There was a problem hiding this comment.
this is fine for now, we need to discuss this vs the "created-by" label tracking for deletion of resources at some point.
|
/test all |
|
/test all |
Checking that a secret exists isn't enough, we want to make sure the contents of the secret are what we expect it to be.
Fixes #330