Create .golangci.yml #349
Merged
Create .golangci.yml #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test all |
jeff-mccoy
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm proposing a linter configuration. One that, for now, will do nothing unless you install
golangci-lintand run it. IDEs can be configured to use it automatically and give you file suggestions.If accepted, later on I'll propose adding a linter check to the CI pipeline, but for now I just want to propose adding the config file that people can choose to either use or not use.
I looked through what it was picking up in our codebase and picked 4 linters to disable, as I don't believe they are something we care about, though totally open to feedback there. I suspect there are other linters we will want to disable because they will identify things that we really don't care much about.
Fix #350