Skip to content
This repository has been archived by the owner on Jan 25, 2022. It is now read-only.

made all rust operators tokenize as unit #59

Merged
merged 1 commit into from
Feb 14, 2016

Conversation

flying-sheep
Copy link
Contributor

this allows fonts like Fira Code and Monoid to render all rust operators with a ligature.

“=>” is an operator used in matching, so it makes sense to include it

@flying-sheep flying-sheep changed the title made ‘=>’ tokenize as unit made all rust operators tokenize as unit Nov 23, 2015
@flying-sheep
Copy link
Contributor Author

i had to get around precedence messing things up by adding a second “Comparison operator” group containing <=, >=, <, and >. should i explain that in the comment?

@zargony
Copy link
Owner

zargony commented Jan 2, 2016

That's great, thanks a lot (I just started to use Fira Code ;)).

A short comment explaining the second comparison group would be nice. Also, one or two cases in test.rs that demonstrate the proper highlighting would be nice as well (unfortunately we don't have automated tests for proper tokenization yet)

@ghost
Copy link

ghost commented Jan 3, 2016

@flying-sheep, I noticed you've (accidentally?) thrown away the bitwise or logical complement operator (!) in your changes.

@flying-sheep
Copy link
Contributor Author

both fixed

@chriskrycho
Copy link

Just following up on this: it looks like -> is working properly, but => is not—so function returns look great; match expressions are still old-school.

@flying-sheep
Copy link
Contributor Author

so you mean with or without my changes?

@chriskrycho
Copy link

@flying-sheep Ah, I see. I incorrectly assumed that a month-old change would be in a release! I'll try the patched version of the package in a bit.

@zargony can you push a release of the package sometime soon? (I understand if you're busy, of course, so "soon" is a relative term, not a demand for immediacy. 😉)

@flying-sheep
Copy link
Contributor Author

yeah, this PR is still open, i.e. the changes aren’t merged. if they were it would be purple, not green 😄

@chriskrycho
Copy link

chriskrycho commented Jan 30, 2016 via email

@flying-sheep
Copy link
Contributor Author

no need to justify 😆

@flying-sheep
Copy link
Contributor Author

@zargony do you want to pull this or do i have to do anything?

zargony added a commit that referenced this pull request Feb 14, 2016
made all rust operators tokenize as unit
@zargony zargony merged commit 48c64db into zargony:master Feb 14, 2016
@zargony
Copy link
Owner

zargony commented Feb 14, 2016

Sorry that it took this long. Great work! Thanks a lot, @flying-sheep

@flying-sheep flying-sheep deleted the macro-arrow branch February 14, 2016 17:07
@flying-sheep
Copy link
Contributor Author

great, thanks!

@chriskrycho
Copy link

chriskrycho commented Feb 14, 2016 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants