You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Builds of the numcodecs-feedstock on conda-forge are currently failing for version 0.6.0 (conda-forge/numcodecs-feedstock#28). The problem is within the following test functions:
# one time encode and save array
if not os.path.exists(enc_fn): # pragma: no cover
enc = codec.encode(arr)
with open(enc_fn, mode='wb') as ef:
> ef.write(enc)
E ValueError: ndarray is not C-contiguous
I think what has happened here is that the fixture data are not being picked up during the conda-forge builds, and so they are being regenerated during the test run. Something has changed since the fixture data was originally generated, and so regeneration of fixture data for the astype and quantize codecs is failing, it looks like on cases where the encoded data returned by the codec is not C-contiguous. Needs a little investigation to determine appropriate fix.
The text was updated successfully, but these errors were encountered:
I think what's happened here is that the input normalisation in the astype and quantize codecs has been relaxed slightly, during the work in #128. Previously in encode() inputs were flattened, but this wasn't strictly necessary, and so now inputs are just coerced to numpy arrays but not flattened. This means that return values from encode() may now also not be flattened, and so could possibly be in fortran order.
Should be possible to fix by modifying the check_backwards_compatibility() function to flatten before attempting to write to file. Should also be possible to verify this does not change the encoded data.
Builds of the numcodecs-feedstock on conda-forge are currently failing for version 0.6.0 (conda-forge/numcodecs-feedstock#28). The problem is within the following test functions:
The error message is:
I think what has happened here is that the fixture data are not being picked up during the conda-forge builds, and so they are being regenerated during the test run. Something has changed since the fixture data was originally generated, and so regeneration of fixture data for the astype and quantize codecs is failing, it looks like on cases where the encoded data returned by the codec is not C-contiguous. Needs a little investigation to determine appropriate fix.
The text was updated successfully, but these errors were encountered: