Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup.py hooks to disable AVX2, SSE2 or C extensions altogether #26

Merged
merged 2 commits into from Mar 1, 2017

Conversation

alimanfoo
Copy link
Member

Resolves #24.

@alimanfoo alimanfoo added this to the 0.1 milestone Mar 1, 2017
@alimanfoo alimanfoo merged commit 076a827 into master Mar 1, 2017
@alimanfoo alimanfoo deleted the noavx2 branch March 1, 2017 13:54
@FrancescAlted
Copy link

FWIW, I am afraid that just avoiding AVX2 instructions in Blosc is not enough. Unless I am missing something, you are not passing any flag for the compiler so as to prevent AVX2 instructions when compiling the Cython extension.

@alimanfoo
Copy link
Member Author

alimanfoo commented Mar 1, 2017 via email

@FrancescAlted
Copy link

Not completely sure about that. To be sure, I would add -mno-avx2.

@FrancescAlted
Copy link

But the -mno-avx2 flag would be useful only in case you want to produce binaries for distribution (alas, conda-forge or wheels).

@alimanfoo
Copy link
Member Author

alimanfoo commented Mar 1, 2017 via email

@alimanfoo
Copy link
Member Author

For reference I made a new PR (#27) which uses -mno-avx2 if DISABLE_NUMCODECS_AVX2 is set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants