Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pickles when loading test fixture data. #193

Merged
merged 1 commit into from
Nov 4, 2019

Conversation

QuLogic
Copy link
Contributor

@QuLogic QuLogic commented Jul 21, 2019

NumPy disabled loading pickles because it was a security risk, but the test fixture data is test data we need to load as pickles.

This is still a security risk though, and just a stopgap solution. See #189.

TODO:

  • [-] Unit tests and/or doctests in docstrings
  • tox -e py37 passes locally
  • tox -e py27 passes locally
  • [-] Docstrings and API docs for any new/modified user-facing classes and functions
  • [-] Changes documented in docs/release.rst
  • [-] tox -e docs passes locally
  • AppVeyor and Travis CI passes
  • Test coverage to 100% (Coveralls passes)

NumPy disabled loading pickles because it was a security risk, but the
test fixture data is test data we need to load as pickles.

This is still a security risk though, and just a stopgap solution.
@jakirkham jakirkham merged commit f068835 into zarr-developers:master Nov 4, 2019
@jakirkham
Copy link
Member

Thanks @QuLogic! 😄

@QuLogic QuLogic deleted the tests-allow-pickle branch November 4, 2019 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants