disable avx2 for wheel #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Thanks Grzegorz! 😄 |
|
@Czaki : any reason for this to still be in "draft" mode? Otherwise, I'd propose releasing 0.7.2 |
Enabled avx2 on Macos and timezone. I live in Europe and already wake up. |
|
😄 Ditto. 👍 |
|
I'm a bit of a night owl. So it works out 😄 Thanks again Grzegorz! Should we try a patch release after this gets merged? 😉 |
|
Everything looks good. I'm merging, but I'll try to get in the Base64 fixture that John requested a review on. I assume 0.7.2 will go out over the course of the European morning unless I hear objections. Thanks all! |
|
Thanks Josh! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #252 (illegal core dump)