Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in CI jobs #468

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Sep 29, 2023

Fixes this error:

▼ Run conda activate env
  conda activate env
  flake8
  shell: /usr/bin/bash -l {0}
  env:
    INPUT_RUN_POST: true
    CONDA_PKGS_DIR: /home/runner/conda_pkgs_dir
./numcodecs/version.py:5:5: F[4](https://github.com/zarr-developers/numcodecs/actions/runs/6349262059/job/17247197031?pr=467#step:9:4)01 'typing.Tuple' imported but unused
Error: Process completed with exit code 1.

Pinning setuptools-scm to a newer version might also fix this issue at some point (pypa/setuptools_scm#482 (comment)), but in any case having linters skip generated files beyond our control is good practice.

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

@DimitriPapadopoulos DimitriPapadopoulos force-pushed the F401_typing.Tuple_imported_but_unused branch from 59493ca to a5756b3 Compare September 29, 2023 09:43
@DimitriPapadopoulos DimitriPapadopoulos changed the title Fix error in CI jobs Fix errors in CI jobs Sep 29, 2023
@DimitriPapadopoulos DimitriPapadopoulos force-pushed the F401_typing.Tuple_imported_but_unused branch 2 times, most recently from 22b06f7 to d1ec8b8 Compare September 29, 2023 10:04
@DimitriPapadopoulos DimitriPapadopoulos changed the title Fix errors in CI jobs Fix error in CI jobs Sep 29, 2023
@DimitriPapadopoulos DimitriPapadopoulos force-pushed the F401_typing.Tuple_imported_but_unused branch from d1ec8b8 to c77d723 Compare October 10, 2023 18:17
@joshmoore
Copy link
Member

Struggling with the OSX builds which are unrelated, so merging proactively.

@joshmoore joshmoore merged commit 6f819a9 into zarr-developers:main Oct 12, 2023
23 of 27 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the F401_typing.Tuple_imported_but_unused branch October 12, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants