Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min Python to 3.10 #531

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Bump min Python to 3.10 #531

merged 4 commits into from
Jun 19, 2024

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented May 24, 2024

As per SPEC 0 (which it says that zarr is signed up to), drop support from Python 3.8/3.9.

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.91%. Comparing base (4abe4be) to head (e144faa).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #531      +/-   ##
==========================================
- Coverage   99.91%   99.91%   -0.01%     
==========================================
  Files          59       59              
  Lines        2323     2318       -5     
==========================================
- Hits         2321     2316       -5     
  Misses          2        2              
Files Coverage Δ
numcodecs/registry.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@martindurant
Copy link
Member

This would be a good time to ensure numpy 2 support, if it isn't already done.

@dstansby
Copy link
Contributor Author

There's an issue here: #521; I'm happy to take a look, but don't want to open too many PRs at once 😄

@normanrz
Copy link
Contributor

It would be great if you could have a look at numpy 2 support.

I wonder if we should remove line of code that codecov complains about? https://app.codecov.io/gh/zarr-developers/numcodecs/pull/531/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zarr-developers

@dstansby dstansby marked this pull request as draft June 19, 2024 08:46
@dstansby dstansby marked this pull request as ready for review June 19, 2024 09:33
@dstansby
Copy link
Contributor Author

This is good to go - the yellow CI jobs are ones no longer run as they're old versions of Python. I think removing these requires some manual adjustment of repository settings from an admin.

@normanrz
Copy link
Contributor

I removed the requirement for py 3.8 and 3.9. Codecov still needs a bump.

@dstansby
Copy link
Contributor Author

From one of the builds:

[2024-06-19T09:51:18.726Z] ['error'] There was an error running the uploader: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 429 - {'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 2676s.', code='throttled')}

So I think someone needs to set up using a codecov token for codecov to start working again.

@normanrz
Copy link
Contributor

Alright. I added the token.

@normanrz normanrz merged commit bc15f51 into zarr-developers:main Jun 19, 2024
21 checks passed
@dstansby dstansby deleted the min-python branch June 19, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants