Couple fixes (#1737)

* Use `is` when comparing `type` of two objects * Unnecessary `None` provided as default
zarr-developers · Apr 2, 2024 · aa9a0d5 · aa9a0d5
1 parent 9864b40
commit aa9a0d5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/zarr/_storage/store.py b/zarr/_storage/store.py
@@ -462,7 +462,7 @@ def inner_store(self) -> Union["StorageTransformer", StoreV3]:
 
     def __eq__(self, other):
         return (
-            type(self) == type(other)
+            type(self) is type(other)
             and self._inner_store == other._inner_store
             and self.get_config() == other.get_config()
         )

diff --git a/zarr/tests/test_core.py b/zarr/tests/test_core.py
@@ -123,7 +123,7 @@ def create_array(self, shape: Union[int, Tuple[int, ...]], **kwargs):
             "compressor": kwargs.pop("compressor", self.compressor),
             "chunk_store": chunk_store,
             "storage_transformers": self.create_storage_transformers(shape),
-            "filters": kwargs.pop("filters", self.create_filters(kwargs.get("dtype", None))),
+            "filters": kwargs.pop("filters", self.create_filters(kwargs.get("dtype"))),
         }
 
         # keyword arguments for array instantiation