Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Yaml Check in Pre-commit #1016

Merged
merged 1 commit into from
May 2, 2022
Merged

Added Yaml Check in Pre-commit #1016

merged 1 commit into from
May 2, 2022

Conversation

Alt-Shivam
Copy link
Member

@Alt-Shivam Alt-Shivam commented Apr 30, 2022

Yaml check for pre-commit.
Related to #1015 and #1012

@joshmoore
Copy link
Member

Thanks, @Alt-Shivam.

Check Yaml...............................................................Passed

Based on your previous comment, isn't it a bit surprising that there are no errors?

@Alt-Shivam
Copy link
Member Author

Yes, @joshmoore Basically I used a different YAML checker in this case.
and this is slightly less strict and only checks the validity.

but in the previous case, the YAML linter is kind of strict one which checks line lengths, brackets, extra spaces and extra symbols in YAML

@Alt-Shivam
Copy link
Member Author

I don't want to make lots of changes in the codebase, so I chose this one.
but If you like the strict one, Then I can also accommodate that one :)

@joshmoore
Copy link
Member

Ah, fair enough. Let's keep https://github.com/adrienverge/yamllint.git on the long-term list, but 👍 for starting with the easier introductions.

@joshmoore joshmoore merged commit 07c8505 into zarr-developers:master May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants