Add some typings informations and typecheck #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Carreau! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-09-18 16:50:15 UTC |
|
Added Typing to storage.py. Note in particular that some function can get bytes/str/anything that |
Carreau
force-pushed
the
mypy
branch
2 times, most recently
from
4ba77d3
to
43ba3e0
Compare
alimanfoo
approved these changes
Sep 18, 2020
jakirkham
approved these changes
Sep 18, 2020
Mostly make it a bit clearer what is allowed/expected where. In particular many of the decode functions allow already decoded objects. Add Typing to store. Note in particular that some function can get bytes/str/anything that can be stringified though others only can get str/None as they don't call normalize on path.
|
rebased to fix conflicts in |
|
All tests are passing and the push was only to fix a trivial conflict in pytest.ini merging. Thanks. |
joshmoore
reviewed
Feb 15, 2021
| @@ -74,27 +76,27 @@ def encode_array_metadata(meta): | |||
| return json_dumps(meta) | |||
|
|
|||
|
|
|||
| def encode_dtype(d): | |||
| def encode_dtype(d: np.dtype) -> str: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly make it a bit clearer what is allowed/expected where.
In particular many of the decode fucntions allow already decoded
objects.
TODO: