-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] getitems / setitems for BaseStore #1040
Conversation
…into getitems_for_all_stores
Codecov Report
@@ Coverage Diff @@
## main #1040 +/- ##
==========================================
- Coverage 99.94% 99.77% -0.18%
==========================================
Files 34 34
Lines 13847 13873 +26
==========================================
+ Hits 13840 13842 +2
- Misses 7 31 +24
|
Any chance of getting the codecov back up, @d-v-b ? |
This is going to take a bit, since it kind of spiraled into a potential refactoring of how slicing works 😰 |
Thanks for working on this Davis! 🙏 We are taking another pass at doing this in PR ( #1131 ). If you have time to look, would welcome your feedback there 🙂 |
@d-v-b - what do you think about closing this. The store api is due to change significantly in |
happy to close! |
This PR adds
getitems
andsetitems
methods toBaseStore
, and removes some redundanthasattr(store, 'getitems')
calls. This makesFSStore
a bit less special and hopefully would make async array methods a little easier to engineer.Tests and docs are WIP
TODO: