Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] getitems / setitems for BaseStore #1040

Closed
wants to merge 11 commits into from

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented May 26, 2022

This PR adds getitems and setitems methods to BaseStore, and removes some redundant hasattr(store, 'getitems') calls. This makes FSStore a bit less special and hopefully would make async array methods a little easier to engineer.

Tests and docs are WIP

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@pep8speaks
Copy link

pep8speaks commented May 26, 2022

Hello @d-v-b! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-05-28 10:29:55 UTC

@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #1040 (7f3e5a4) into main (761bbed) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

❗ Current head 7f3e5a4 differs from pull request most recent head 9f74667. Consider uploading reports for the commit 9f74667 to get more accurate results

@@            Coverage Diff             @@
##             main    #1040      +/-   ##
==========================================
- Coverage   99.94%   99.77%   -0.18%     
==========================================
  Files          34       34              
  Lines       13847    13873      +26     
==========================================
+ Hits        13840    13842       +2     
- Misses          7       31      +24     
Impacted Files Coverage Δ
zarr/_storage/store.py 100.00% <100.00%> (ø)
zarr/core.py 96.83% <100.00%> (-3.17%) ⬇️
zarr/storage.py 100.00% <100.00%> (ø)
zarr/tests/test_storage.py 100.00% <100.00%> (ø)

@joshmoore
Copy link
Member

Any chance of getting the codecov back up, @d-v-b ?

@d-v-b
Copy link
Contributor Author

d-v-b commented Jun 23, 2022

This is going to take a bit, since it kind of spiraled into a potential refactoring of how slicing works 😰

@jakirkham
Copy link
Member

Thanks for working on this Davis! 🙏

We are taking another pass at doing this in PR ( #1131 ). If you have time to look, would welcome your feedback there 🙂

@jakirkham
Copy link
Member

@madsbk , could you please look over this and see if there are things we need to still include from it since PR ( #1131 ) has been merged?

@jhamman
Copy link
Member

jhamman commented Dec 7, 2023

@d-v-b - what do you think about closing this. The store api is due to change significantly in v3 so I'm not sure this is worth finishing.

@d-v-b
Copy link
Contributor Author

d-v-b commented Dec 7, 2023

happy to close!

@d-v-b d-v-b closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants