Fix deepsource.io issues #1080
Merged
Fix deepsource.io issues #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1080 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 34 34
Lines 13846 13846
=======================================
Hits 13839 13839
Misses 7 7
|
joshmoore
approved these changes
Jul 18, 2022
There was a problem hiding this comment.
Changes look good, @DimitriPapadopoulos. Can you update docs/releases.rst?
An instance of the pre-Python 2.5 ternary syntax is being used. Using [condition] and [on_true] or [on_false] may give wrong results when on_true has a false boolean value.
Unlike pop() which raises a KeyError by default, get() returns None by default.
DimitriPapadopoulos
force-pushed
the
fix_deepsource.io_issues
branch
from
8204a5d
to
4d2343c
Compare
|
Done. |
|
Thanks, @DimitriPapadopoulos! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://deepsource.io/gh/DimitriPapadopoulos/zarr-python/ for complete list of issues.
Not all issues make sense. Some of them are false positives, others may result in less readable code.
TODO: