Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow black to be run on any Python version #1549

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Allow black to be run on any Python version #1549

merged 3 commits into from
Oct 25, 2023

Conversation

dstansby
Copy link
Contributor

This removes the limitation of running black via pre-commit on Python 3.8. The python version that black is run on doesn't actually affect the output, so this change doesn't make a difference to what black does.

Fixes #1545

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Oct 25, 2023
@d-v-b
Copy link
Contributor

d-v-b commented Oct 25, 2023

looks good, thank you!

@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Oct 25, 2023
@d-v-b
Copy link
Contributor

d-v-b commented Oct 25, 2023

@dstansby I added some release notes, let me know if you object to them. if not, I'm going to merge this.

@dstansby
Copy link
Contributor Author

👍 looks good, thanks for showing me an example, I can add release notes to my other PRs 😄

@d-v-b d-v-b merged commit a9d516b into zarr-developers:main Oct 25, 2023
21 checks passed
dstansby added a commit to dstansby/zarr-python that referenced this pull request Oct 31, 2023
@dstansby @d-v-b
Allow black to be run on any Python version (zarr-developers#1549)
a9938c0 
* Allow black to be run on any Python version

* docs: add release notes

* docs: whitespace

---------

Co-authored-by: Davis Vann Bennett <davis.v.bennett@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-v-b d-v-b d-v-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not possible to run pre-commit on all Python versions
2 participants
@dstansby @d-v-b