New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure fs exceptions are raised if not MissingFs exceptions (clone) #1604
Conversation
It would be nice to get the workflows authorized so I could see what more to fix and document in release notes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1604 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 38 38
Lines 14580 14604 +24
=======================================
+ Hits 14579 14603 +24
Misses 1 1
|
Failing test is the same seen in #1611, something with Azure connection. |
Apologies for the slowness. It's the end of year crunch. Actions launched.
IIUC, this has been happening more frequently recently. A relaunch usually helps. I'll keep an eye on it. |
@joshmoore Trying to help with another merge to main. Maybe not helpful though ... |
Scan of the 178 failed tests indicates |
@itcarroll, it looks like re-running the jobs worked! |
@joshmoore I know that no issue was created to precipitate @martindurant's original PR, but this fixes an actual, real, silent, bug, so it would be great to finish it off. Thanks! |
This has been quite the quest -- thanks @itcarroll for hanging in there. @martindurant - are you happy with this solution? Would love to get this into a release (tomorrow 🤞). |
note: This PR is a copy of PR #1237 which had become stale. Description from @martindurant is:
TODO: