Optimize Array.info and Group.info #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid repeated computes of the same value (getsize)
Apparently IPython will run both __repr__ and _repr_html_ so we were calling `getsize` twice.
dcherian
commented
Mar 29, 2024
|
|
||
| def __repr__(self): | ||
| items = self.obj.info_items() | ||
| return info_text_report(items) | ||
| return info_text_report(self.items) |
There was a problem hiding this comment.
The previous version called info_items twice per repr in a notebook.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1733 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 38 38
Lines 14611 14610 -1
=======================================
- Hits 14610 14609 -1
Misses 1 1
|
dcherian
commented
Mar 30, 2024
Co-authored-by: Joe Hamman <jhamman1@gmail.com>
dcherian
added a commit
to dcherian/zarr-python
that referenced
this pull request
Apr 2, 2024
* main: Couple fixes (zarr-developers#1737) Bump actions/setup-python from 5.0.0 to 5.1.0 (zarr-developers#1736) Optimize Array.info and Group.info (zarr-developers#1733) chore: update pre-commit hooks (zarr-developers#1738)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid repeated computes of the same value
getsizeFrom 6 getsize requests to 1.
TODO: