-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make typing strict #1879
Make typing strict #1879
Conversation
6bf7fa1
to
31f649d
Compare
@dstansby - let us know when this is ready for a review. |
31f649d
to
08ddbab
Compare
2b5e384
to
132a65d
Compare
馃憤 should be good to review now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dstansby!
@@ -18,6 +18,6 @@ | |||
|
|||
def parse_indexing_order(data: Any) -> Literal["C", "F"]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noting that this function also exists in zarr.common
... No need to fix here but we don't need both.
This enables strict mypy typing, fixing (almost) #1783 馃帀
TODO: