Finish typing zarr.metadata #1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 this should be updated now |
jhamman
reviewed
May 21, 2024
| @@ -22,13 +22,13 @@ | |||
| @dataclass(frozen=True) | |||
| class ChunkGrid(Metadata): | |||
| @classmethod | |||
| def from_dict(cls, data: dict[str, JSON]) -> ChunkGrid: | |||
| def from_dict(cls, data: dict[str, JSON] | ChunkGrid) -> ChunkGrid: | |||
There was a problem hiding this comment.
your change is fine but I don't know why from_dict accepts a ChunkGrid object. 🤷
jhamman
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes typing
zarr.metadata. Alongside adding typing, it made sense to fix/improve some of the typing elsewhere that's called byArrayMetadata.__init__.TODO: