Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some misc typing fixes #1892

Closed
wants to merge 1 commit into from
Closed

Some misc typing fixes #1892

wants to merge 1 commit into from

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented May 18, 2024 •
edited

Some misc typing fixes. I'm not sure why pre-commit isn't catching these but VSCode is, I will do a bit of investigation... For now thought it was worth adding some of the fixes.

Update: I found the issue: #1893

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@dstansby dstansby closed this May 18, 2024
@dstansby dstansby deleted the misc-typing-fixes branch May 18, 2024 10:12
@jhamman jhamman added V3 Related to compatibility with V3 spec types labels Jun 1, 2024
@jhamman jhamman added this to the 3.0.0.alpha milestone Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
types V3 Related to compatibility with V3 spec
Projects
None yet
Milestone
3.0.0.alpha
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dstansby @jhamman