Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(typing): add py.typed file to package root #1935

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Jun 1, 2024

This is an epic PR that I couldn't refrain from issuing myself... Sorry @dstansby 馃槈 !

closed #1566

@jhamman jhamman added V3 Related to compatibility with V3 spec types labels Jun 1, 2024
@jhamman jhamman added this to the 3.0.0.alpha milestone Jun 1, 2024
Copy link
Contributor

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth fixing the rest of the [[tool.mypy.overrides]] sections in pyproject.toml first before adding this?

@jhamman
Copy link
Member Author

jhamman commented Jun 1, 2024

sections

Happy to wait! We're not going to end up with a merge conflict here 馃槈

Copy link
Contributor

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jhamman jhamman merged commit c2a1d2e into zarr-developers:v3 Jun 2, 2024
18 checks passed
d-v-b pushed a commit to d-v-b/zarr-python that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
types V3 Related to compatibility with V3 spec
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Declare typing support via py.typed file
3 participants