Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] StoreTests[RemoteStore] #1956

Closed
wants to merge 27 commits into from
Closed

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Jun 9, 2024

Attempts to specialize StoreTests with RemoteStore. Depends on #1785.

This is currently broken because I can't figure out the correct way to link up the s3 fixture with the StoreTests instance. Help would be appreciated!

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@d-v-b
Copy link
Contributor Author

d-v-b commented Jun 10, 2024

We are getting failures like this:

FAILED tests/v3/test_store/test_remote.py::TestRemoteStoreS3::test_get_partial_values[key_ranges3] - botocore.exceptions.HTTPClientError: An HTTP Client raised an unhandled exception: Task <Task pending name='Task-643293' coro=<_run_coros_in_chunks.<locals>._run_coro() running at /home/runner/.local/share/hatch/env/virtual/zarr/nOVTQ5-s/test.py3.11-1.24-optional/lib/python3.11/site-packages/fsspec/asyn.py:245> cb=[_wait.<locals>._on_completion() at /opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/asyncio/tasks.py:519]> got Future <Future pending cb=[BaseSelectorEventLoop._sock_write_done(17, handle=<Handle BaseS....0.1', 5555))>)()]> attached to a different loop

cc @martindurant in case you have any insights here. This builds off #1785, but since I'm touching a lot of code here, I spun it out into a separate PR (and I opened a corresponding PR against your branch, which you can ignore if you would rather look here).

@jhamman jhamman closed this Jun 11, 2024
@jhamman
Copy link
Member

jhamman commented Jun 11, 2024

Thanks @d-v-b for advancing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants