Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt storage tests for changes in fsspec (#1819) (#1679) #1970

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adapt storage tests for changes in fsspec (#1819) (#1679) #1970

wants to merge 1 commit into from

Conversation

AdamWill
Copy link

@AdamWill AdamWill commented Jun 17, 2024 •
edited
Loading

This is adapted from the fixes that were rolled into #1785 for the v3 branch.

TODO:

  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

Deleted TODO items are not applicable as this changes no code, only tests.

@AdamWill
Adapt storage tests for changes in fsspec (zarr-developers#1819) (zar…
81707e5 
…r-developers#1679)

This is adapted from the fixes that were rolled into
zarr-developers#1785 for the
v3 branch.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
@AdamWill
Copy link
Author

AdamWill commented Jun 17, 2024 •
edited
Loading

On v3 the check in test_hierarchy was commented out entirely, but that seems excessive to me. The comment # no exception raised if path does not exist or is leaf indicates the primary point of these checks is to make sure the listdir calls run without causing an assertion, and we can still do that, and check that the result is one of the two we know are possible.

@dstansby dstansby mentioned this pull request Jul 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@AdamWill