Change data type names and change endianness to be handled by a codec #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @QuLogic (in case you have thoughts here) |
|
I believe all FITS integer values are big-endian, for reference. |
jbms
force-pushed
the
rename-data-types
branch
from
fd8d702
to
8694e49
Compare
jstriebel
reviewed
Oct 21, 2022
jstriebel
reviewed
Nov 3, 2022
|
LGTM 👍 |
meggart
approved these changes
Nov 4, 2022
jstriebel
approved these changes
Nov 4, 2022
|
Merging based on current approvals. |
Merged
This was referenced Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seemed to be consensus to rename data types to more commonly-used names, rather than the NumPy type string-derived names.
There also seemed to be potential agreement to handle endianness via a codec rather than as part of the data type, as long as there is a migration path for zarr v2 data that does not require any chunk re-encoding.