LRU store cache #223
Merged
LRU store cache #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimanfoo
commented
Dec 31, 2017
zarr/storage.py
Outdated
| with self._mutex: | ||
| if self._keys_cache is None: | ||
| self._keys_cache = list(self._store.keys()) | ||
| return iter(self._keys_cache) |
There was a problem hiding this comment.
Should probably move this under the mutex lock.
|
cc @jhamman, @mrocklin, this PR provides another strategy for improving performance with cloud stores, adding a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
zarr.storage.LRUStoreCacheclass which can be used as a cache layer for slow stores (e.g., stores accessed via network).Also in developing this PR some inconsistencies in the way that
zarr.storage.getsize()was implemented for different store types came to light and have been fixed.TODO: