[Host.AzureServiceBus] Add option for replacing already defined rules in ASB subscription #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew ones. Signed-off-by: Paweł Mazurek <ziurek0@gmail.com>
zarusz
reviewed
May 4, 2023
src/SlimMessageBus.Host.AzureServiceBus/ServiceBusTopologyService.cs
Outdated
Show resolved
Hide resolved
Signed-off-by: Paweł Mazurek <ziurek0@gmail.com>
zarusz
reviewed
May 4, 2023
src/SlimMessageBus.Host.AzureServiceBus/ServiceBusTopologyService.cs
Outdated
Show resolved
Hide resolved
Signed-off-by: Paweł Mazurek <ziurek0@gmail.com>
…_replace_subscription_rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds option
CanConsumerReplaceSubscriptionFilterswhich is set tofalseby default.If it's
true, then whenever any rules are already defined for ASB subscription, then SMB will replace them with newly defined ones.Context: I observed an issue, if a subscription was defined without the rules, and after some time I decided to add some, then subscription had two rules:
$DefaultExpected behaviour is to remove the default one, once new rules are declared.
How to use this behaviour: set
ServiceBusTopologySettings'sCanConsumerReplaceSubscriptionFiltersflag to true.Once you do it, if you defined any set of rules, they will override already exisiting ones.
NOTE: It compares already existing rules by name, so let say: if there is a rule with name
ruleand then you define new rule with namerulebut different condition, it won't override it. To be discussed this should work like this, or rather it should compare condition as well.Docs not yet updated.
Signed-off-by: Paweł Mazurek ziurek0@gmail.com