Fix User Profile monitoring #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored that section of the code to properly check for profile updates. Involves a workaround where the payload data is normalised within the function - this should ideally be applied to the whole script, but I wanted to fix this one feature for now
Closed
zastlx
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Notes
User Profile Monitoring only works when viewing a DM with a user, or when viewing a user's profile directly.
Discord itself is responsible for sending the
USER_PROFILE_FETCH_SUCCESSevent, which only happens in those specific cases.Perhaps in the future, I can find a workaround to poll whitelisted users periodically. Until then, this PR fixes bugs, and has not broken any existing features, so I am proposing it for merge.