forked from m21/mastercore
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
8a60ea0 QA: add RPC tests for error reporting of "signrawtransaction" (dexX7) 4ab1fae RPC: show script verification errors in "signrawtransaction" result (dexX7)
- Loading branch information
Showing
3 changed files
with
148 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| #!/usr/bin/env python2 | ||
| # Copyright (c) 2015 The Bitcoin Core developers | ||
| # Distributed under the MIT software license, see the accompanying | ||
| # file COPYING or http://www.opensource.org/licenses/mit-license.php. | ||
|
|
||
| from test_framework import BitcoinTestFramework | ||
| from util import * | ||
|
|
||
|
|
||
| class SignRawTransactionsTest(BitcoinTestFramework): | ||
| """Tests transaction signing via RPC command "signrawtransaction".""" | ||
|
|
||
| def setup_chain(self): | ||
| print('Initializing test directory ' + self.options.tmpdir) | ||
| initialize_chain_clean(self.options.tmpdir, 1) | ||
|
|
||
| def setup_network(self, split=False): | ||
| self.nodes = start_nodes(1, self.options.tmpdir) | ||
| self.is_network_split = False | ||
|
|
||
| def successful_signing_test(self): | ||
| """Creates and signs a valid raw transaction with one input. | ||
| Expected results: | ||
| 1) The transaction has a complete set of signatures | ||
| 2) No script verification error occurred""" | ||
| privKeys = ['cUeKHd5orzT3mz8P9pxyREHfsWtVfgsfDjiZZBcjUBAaGk1BTj7N'] | ||
|
|
||
| inputs = [ | ||
| # Valid pay-to-pubkey script | ||
| {'txid': '9b907ef1e3c26fc71fe4a4b3580bc75264112f95050014157059c736f0202e71', 'vout': 0, | ||
| 'scriptPubKey': '76a91460baa0f494b38ce3c940dea67f3804dc52d1fb9488ac'} | ||
| ] | ||
|
|
||
| outputs = {'mpLQjfK79b7CCV4VMJWEWAj5Mpx8Up5zxB': 0.1} | ||
|
|
||
| rawTx = self.nodes[0].createrawtransaction(inputs, outputs) | ||
| rawTxSigned = self.nodes[0].signrawtransaction(rawTx, inputs, privKeys) | ||
|
|
||
| # 1) The transaction has a complete set of signatures | ||
| assert 'complete' in rawTxSigned | ||
| assert_equal(rawTxSigned['complete'], True) | ||
|
|
||
| # 2) No script verification error occurred | ||
| assert 'errors' not in rawTxSigned | ||
|
|
||
| def script_verification_error_test(self): | ||
| """Creates and signs a raw transaction with valid (vin 0), invalid (vin 1) and one missing (vin 2) input script. | ||
| Expected results: | ||
| 3) The transaction has no complete set of signatures | ||
| 4) Two script verification errors occurred | ||
| 5) Script verification errors have certain properties ("txid", "vout", "scriptSig", "sequence", "error") | ||
| 6) The verification errors refer to the invalid (vin 1) and missing input (vin 2)""" | ||
| privKeys = ['cUeKHd5orzT3mz8P9pxyREHfsWtVfgsfDjiZZBcjUBAaGk1BTj7N'] | ||
|
|
||
| inputs = [ | ||
| # Valid pay-to-pubkey script | ||
| {'txid': '9b907ef1e3c26fc71fe4a4b3580bc75264112f95050014157059c736f0202e71', 'vout': 0}, | ||
| # Invalid script | ||
| {'txid': '5b8673686910442c644b1f4993d8f7753c7c8fcb5c87ee40d56eaeef25204547', 'vout': 7}, | ||
| # Missing scriptPubKey | ||
| {'txid': '9b907ef1e3c26fc71fe4a4b3580bc75264112f95050014157059c736f0202e71', 'vout': 1}, | ||
| ] | ||
|
|
||
| scripts = [ | ||
| # Valid pay-to-pubkey script | ||
| {'txid': '9b907ef1e3c26fc71fe4a4b3580bc75264112f95050014157059c736f0202e71', 'vout': 0, | ||
| 'scriptPubKey': '76a91460baa0f494b38ce3c940dea67f3804dc52d1fb9488ac'}, | ||
| # Invalid script | ||
| {'txid': '5b8673686910442c644b1f4993d8f7753c7c8fcb5c87ee40d56eaeef25204547', 'vout': 7, | ||
| 'scriptPubKey': 'badbadbadbad'} | ||
| ] | ||
|
|
||
| outputs = {'mpLQjfK79b7CCV4VMJWEWAj5Mpx8Up5zxB': 0.1} | ||
|
|
||
| rawTx = self.nodes[0].createrawtransaction(inputs, outputs) | ||
| rawTxSigned = self.nodes[0].signrawtransaction(rawTx, scripts, privKeys) | ||
|
|
||
| # 3) The transaction has no complete set of signatures | ||
| assert 'complete' in rawTxSigned | ||
| assert_equal(rawTxSigned['complete'], False) | ||
|
|
||
| # 4) Two script verification errors occurred | ||
| assert 'errors' in rawTxSigned | ||
| assert_equal(len(rawTxSigned['errors']), 2) | ||
|
|
||
| # 5) Script verification errors have certain properties | ||
| assert 'txid' in rawTxSigned['errors'][0] | ||
| assert 'vout' in rawTxSigned['errors'][0] | ||
| assert 'scriptSig' in rawTxSigned['errors'][0] | ||
| assert 'sequence' in rawTxSigned['errors'][0] | ||
| assert 'error' in rawTxSigned['errors'][0] | ||
|
|
||
| # 6) The verification errors refer to the invalid (vin 1) and missing input (vin 2) | ||
| assert_equal(rawTxSigned['errors'][0]['txid'], inputs[1]['txid']) | ||
| assert_equal(rawTxSigned['errors'][0]['vout'], inputs[1]['vout']) | ||
| assert_equal(rawTxSigned['errors'][1]['txid'], inputs[2]['txid']) | ||
| assert_equal(rawTxSigned['errors'][1]['vout'], inputs[2]['vout']) | ||
|
|
||
| def run_test(self): | ||
| self.successful_signing_test() | ||
| self.script_verification_error_test() | ||
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| SignRawTransactionsTest().main() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters