Replace global balance arrays with std::map #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -61,11 +61,6 @@ | |||
| #define DECORATION_SIZE 64 | |||
| #define NUM_ITEMS 6 // 3 - number of recent transactions to display | |||
|
|
|||
| extern uint64_t global_balance_money_maineco[100000]; | |||
There was a problem hiding this comment.
No need to extern the variables here, because they are already already provided via mastercore.h.
1. Doesn't cover full range of potential properties, can result in out-of-bounds violation 2. No need to reserve 100000 elements each 3. [] operator reads an element at position, if key exists, or inserts an element, if not 4. Balances are int64_t
dexX7
force-pushed
the
oc-0.10-ui-balance-arrays-to-map
branch
from
5d272e8
to
25b6cb4
Compare
|
Agreed, thanks dude :) |
zathras-crypto
added a commit
that referenced
this pull request
May 17, 2015
Replace global balance arrays with std::map
zathras-crypto
pushed a commit
that referenced
this pull request
Jun 3, 2015
3d647f5 Update MetaDEx network/transaction fields (dexX7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a resubmission of mastercoin-MSC#258.