Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restarting server with broken hot-deployed code #57

Closed
myroslav opened this issue Jun 1, 2013 · 2 comments
Closed

Restarting server with broken hot-deployed code #57

myroslav opened this issue Jun 1, 2013 · 2 comments
Milestone

Comments

@myroslav
Copy link
Contributor

myroslav commented Jun 1, 2013

If hot-deployed code with Syntax Error is uploaded to server (via pickup-dir) the error is logged to logs, and that is normal. However rebooting server after that makes that server fail on startup (with Syntax Error in logs) thus making impossible to hot-deploy corrected code to this server. Deployment corrected code to other server doesn't help since server does not reach point when it can accept hot-deployed code, and does not sync hot-deploy state from other servers (See #56).

@dsuch
Copy link
Collaborator

dsuch commented Jun 1, 2013

Right, for 1.2 I will make it so that hot-deployed modules with syntax errors (but none other) are moved to a separate directory that won't be imported when a server starts up.

For now - please delete any such hot-deployed module manually from work/hot-deploy/current [1]

[1] https://zato.io/docs/admin/guide/install-config/config-server.html#hot-deploy-current-work-dir

dsuch pushed a commit that referenced this issue Jun 25, 2013
@dsuch
Copy link
Collaborator

dsuch commented Jun 25, 2013

OK, turns out it's much easier and cleaner to simply catch any errors during imports (syntax-related ones including) and log an error message. It was done in 6c85bd9 and was in fact added to the latest hotfixes a moment ago. Thanks again! :-)

https://zato.io/docs/admin/guide/hotfixes.html

@dsuch dsuch closed this as completed Jun 25, 2013
dsuch pushed a commit that referenced this issue Jun 25, 2013
dsuch added a commit that referenced this issue Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants