Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also adjust console font size #10

Merged
merged 2 commits into from
Mar 1, 2015
Merged

Also adjust console font size #10

merged 2 commits into from
Mar 1, 2015

Conversation

allewun
Copy link
Contributor

@allewun allewun commented Feb 25, 2015

This works, but there seems to be a small bug in Xcode. When adjusting sizes, if you switch directions (from ⌘- to ⌘+ or vice versa), the first size change is not correct. Checking the console font size in preference panel shows that it's correct, but Xcode renders it incorrectly. Any ideas?

Size (visually) Size (acutal)
Action
Before After Before After
⌘+ 10 10 10 11
⌘+ 10 11 11 12
⌘+ 11 12 12 13
⌘- 12 13 13 12
⌘- 13 12 12 11

@allewun
Copy link
Contributor Author

allewun commented Mar 1, 2015

The previous issue is now fixed. I've also separated font size changes depending on cursor focus. This lets you modify console and editor font sizes independently.

zats added a commit that referenced this pull request Mar 1, 2015
@zats zats merged commit 84deff2 into zats:master Mar 1, 2015
@zats
Copy link
Owner

zats commented Mar 1, 2015

Thanks for the PR, I merged it, however I modified it a bit:
to keep it simple, I think it's better to modify both console & editor fonts at once.
Plus some minor code changes.
Nevertheless, thank you for your contribution!

@allewun
Copy link
Contributor Author

allewun commented Mar 11, 2015

I agree that simplicity is nice, but there's a benefit to having separate size controls.

A recent example (actually, this was why I decided to implement this feature):

  • Using po [[UIWindow keyWindow] recursiveDescription] in the console results in very long but structured output. There's benefit to being able to shrink the font size so that you can see the entire view hierarchy, but still keeping your editor size.

screen shot 2015-03-11 at 1 17 02 pm copy copy

Would you consider keeping that feature? I'm currently just using my fork.

Great work on this plugin btw! Can't believe Apple chose not to include such a basic feature.

@zats
Copy link
Owner

zats commented Mar 11, 2015

hey @allewun, first of all, thank you for the contribution once again, great work!
as for the merging this change back into the main trunk: I'm currently swamped with work, I hope I get a window some time soon to think of this feature.

Thanks a lot once again! You rock!

@allewun
Copy link
Contributor Author

allewun commented Mar 11, 2015

No worries @zats! I completely understand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants